Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Conditional close signal channel empty #294

Merged
merged 4 commits into from
Jul 5, 2023

Conversation

longquanzheng
Copy link
Contributor

For #291

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #294 (f1b10c3) into main (89c24fc) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   71.29%   71.45%   +0.15%     
==========================================
  Files          53       53              
  Lines        4348     4358      +10     
==========================================
+ Hits         3100     3114      +14     
+ Misses       1014     1010       -4     
  Partials      234      234              
Impacted Files Coverage Δ
service/interpreter/workflowImpl.go 83.19% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@longquanzheng longquanzheng merged commit 24d444f into main Jul 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant